Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deface to deps #57

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Add deface to deps #57

merged 1 commit into from
Jul 10, 2020

Conversation

elia
Copy link
Member

@elia elia commented Jul 9, 2020

Otherwise it breaks on apps that are not depending on deface.

@elia elia added the bug Something isn't working label Jul 9, 2020
@elia elia self-assigned this Jul 9, 2020
@elia
We rely on Deface for overrides
6fe9294 
Deface is not a solidus dependency, but rather one of
`solidus_auth_devise`, would be wrong to assume it's there.
@elia elia force-pushed the elia/add-deface-to-deps branch from 0292cf6 to 6fe9294 Compare July 9, 2020 14:10
@elia elia requested a review from seand7565 July 9, 2020 14:27
@elia elia marked this pull request as ready for review July 9, 2020 14:27
seand7565
seand7565 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@seand7565 seand7565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 👍

@elia elia merged commit a929344 into master Jul 10, 2020
@elia elia deleted the elia/add-deface-to-deps branch July 10, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seand7565 seand7565 seand7565 approved these changes

Assignees

@elia elia

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @seand7565