Verify email address is verified before allowing payment method to be available #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seand7565
added
solidus admin
We want to ensure that the users PayPal email is verified before accepting payments with this payment_method, so we're starting by defaulting user availability to false on payment_method creation.
elia
approved these changes
Jul 15, 2020
Comment on lines
3
to
5
| <span class="hint-tooltip" title="" data-content="You must verify that your email is confirmed with PayPal before allowing users to check out."> | ||
| <i class="fa fa-info-circle"></i> | ||
| </span> |
There was a problem hiding this comment.
Would be nice to fully support translations with
Suggested change
| <span class="hint-tooltip" title="" data-content="You must verify that your email is confirmed with PayPal before allowing users to check out."> | |
| <i class="fa fa-info-circle"></i> | |
| </span> | |
| <%= f.field_hint :available_to_users %> |
plus adding spree.hints.solidus_paypal_commerce_platform/payment_method.available_to_users to locales.yml
There was a problem hiding this comment.
Of course, I always forget the translations. Also, I had no idea f.field_hint was a thing, that's seriously cool. Thanks!
Unless `paypal_email_confirmed` is checked, `available_to_user` will be disabled - this is to provide a reminder to the user that they need to verify their email with PayPal.
|
Not sure if GitHub is having issues or if the problem is on my end, but pushing to my branch didn't update this PR. Closing this one to get an updated PR up! |
|
Oookay, reopening - as soon as I closed it the PR updated. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that the users PayPal email is verified before
accepting payments with this payment_method, so we're defaulting
payment method availability to false and requiring the user to verify
that their email is confirmed before allowing the payment_method
to be available to users.
Fixes #9