Add skip migration option to installer #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kennyadsl
reviewed
Oct 1, 2020
lib/generators/solidus_paypal_commerce_platform/install/install_generator.rb
Outdated
Show resolved
Hide resolved
When the user installs this extension as part of the initial Solidus install, we don't want to ask them if they want to migrate - in fact, we'd like to skip migration entirely until the final migration happens as part of the apps setup. This option allows for that!
seand7565
force-pushed
the
skip_migrations
branch
from
ac0088d to
4ef4595
Compare
|
@seand7565 are you addressing the code linting concerns into another PR? |
I'm working on this - will submit a separate PR. There's something odd going on between rubocop locally and on CircleCI, as @elia & I are getting different results locally. Trying to figure that out! |
kennyadsl
approved these changes
Oct 5, 2020
|
@kennyadsl FYI this was an issue with solidus_dev_support that has since been fixed with a new release. 🎉 |
elia
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user installs this extension as part of the initial Solidus
install, we don't want to ask them if they want to migrate - in fact,
we'd like to skip migration entirely until the final migration happens
as part of the apps setup. This option allows for that!