Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better token auth #176

Closed
magnusvk opened this issue Jul 14, 2015 · 3 comments
Closed

Better token auth #176

magnusvk opened this issue Jul 14, 2015 · 3 comments
Labels
changelog:solidus_api Changes to the solidus_api gem
Milestone

Comments

@magnusvk
Copy link
Contributor

We currently have a separate token auth solution at Bonobos that is considerably better than the default in Spree now:

  • not susceptible to timing attacks
  • stores hashed tokens, rather than cleartext tokens in the database
  • supports multiple tokens per user
  • supports token expiration

I've started work on breaking this out into a devise module, but there's more work to do there. I think we should make this a part of solidus_auth_devise by default and remove the current api_key from spree_users.

@jhawthorn jhawthorn added the changelog:solidus_api Changes to the solidus_api gem label Jul 21, 2015
@athal7 athal7 added this to the Future milestone Aug 11, 2015
@gmacdougall
Copy link
Member

Closing due to being stale.

@magnusvk
Copy link
Contributor Author

magnusvk commented Oct 4, 2017

👋 blast from the past here. 🙃

@skycocker
Copy link

@magnusvk and others as well: in case you were still interested, I created a fork of solidus that supports devise_token_auth: https://github.com/skycocker/solidus_devise_token_auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_api Changes to the solidus_api gem
Projects
None yet
Development

No branches or pull requests

5 participants