From 012db5c731996a12b9ce7b783b5e673eddd55a83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20Busqu=C3=A9?= Date: Tue, 21 Jun 2022 18:43:52 +0200 Subject: [PATCH] Fail with `raise` when the storage adapter is not supported When `abort` is raised on a CI test, it's skipped, but it's not counted as a failure, giving an obscure error result on the corresponding job. See f1f9ca1a01c46ceaaec9d2ba5d9d7c7982742aa8 for an example. --- core/app/models/concerns/spree/active_storage_adapter.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/app/models/concerns/spree/active_storage_adapter.rb b/core/app/models/concerns/spree/active_storage_adapter.rb index a26f1549e78..1a6f93e20db 100644 --- a/core/app/models/concerns/spree/active_storage_adapter.rb +++ b/core/app/models/concerns/spree/active_storage_adapter.rb @@ -10,7 +10,7 @@ module ActiveStorageAdapter included do next if Rails.gem_version >= Gem::Version.new('6.1.0.alpha') - abort <<~MESSAGE + raise <<~MESSAGE Configuration Error: Solidus ActiveStorage attachment adpater requires Rails >= 6.1.0. Spree::Config.image_attachment_module preference is set to #{Spree::Config.image_attachment_module}