Revert: Use the page name if the page has no SEO title (#646) #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jan 15, 2017
OskarStark
approved these changes
Jan 16, 2017
|
@core23 @OskarStark actually there are always a title if default one is defined in the config, so after this patch page titles just don't appear at all. I have just faced this issue when realized that all my pages have the same title - the default one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targetting this branch, because this is a bugfix.
Reverts #646 partially
Changelog
Subject
Reverts my PR from last year, because any existing title was overwritten. This PR fixes this behavior, so the title will be set if there isn't any.