Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All CI workflows for publishing docker images to ACR broke because repo moved to sonic-net #342

Closed
chrispsommers opened this issue Feb 16, 2023 · 0 comments
Closed

All CI workflows for publishing docker images to ACR broke because repo moved to sonic-net #342

chrispsommers opened this issue Feb 16, 2023 · 0 comments

Comments

@chrispsommers
Copy link
Collaborator

chrispsommers commented Feb 16, 2023 •
edited
Loading

DASH Github workflow .yml files contain conditionals such as the following, to publish docker images when run from the main repo (and not from a fork). These are now unintentionally skipped because the repo moved to sonic-net/DASH. This silent failure was caused by repo migration without considering the side-effects.

Previous PR #321 failed to consider .yml files.

      if: ${{ github.event_name != 'pull_request' && github.repository == 'Azure/DASH' }}
chrispsommers added a commit to chrispsommers/DASH that referenced this issue Feb 16, 2023
@chrispsommers
Fix sonic-net#342 plus a few more .md and .svg files containing Azure…
444d6f6 
…/DASH string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrispsommers