Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DASH outbound metering to Sonic HLD #296

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Add DASH outbound metering to Sonic HLD #296

merged 1 commit into from
Mar 15, 2023

Conversation

vijasrin
Copy link
Collaborator

@vijasrin vijasrin commented Dec 8, 2022 •
edited
Loading 

- Metering Policy, rule and meter schemas
- Metering feature description
- Update DASH outbound packet processing pipeline
- Update meter examples
- Adding pipeline diagram for outbound meter

@vijasrin
Copy link
Collaborator Author

vijasrin commented Dec 8, 2022 •
edited
Loading

@prsunny: plz review

@prsunny
Copy link
Collaborator

prsunny commented Dec 8, 2022

@vijasrin , thank you for the proposal. Could you also add an example section that captures the flow?

@vijasrin vijasrin changed the title Add DASH metering to Sonic HLD Add DASH outbound metering to Sonic HLD Jan 25, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 6, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vijasrin / name: Vijay Srinivasan (86ad0c9)

@KrisNey-MSFT
Copy link
Collaborator

KrisNey-MSFT commented Feb 8, 2023 •
edited
Loading

This is mainly on App_DB schema and will go independently. Possibly look tomerge by end of the week 2/10/2023.

@vijasrin vijasrin force-pushed the patch-1 branch 6 times, most recently from e65095b to 86ad0c9 Compare February 14, 2023 22:40
mhanif
mhanif reviewed Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@mhanif mhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for a minor name change

@vijasrin
Add DASH outbound metering to Sonic HLD
785830d 
- Metering Policy, rule and meter schemas
- Metering feature description
- Update DASH outbound packet processing pipeline
- Update meter examples
- Adding pipeline diagram for outbound meter
@KrisNey-MSFT
Copy link
Collaborator

Hanif & Guohan please approve if you have time

mhanif
mhanif approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@mhanif mhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prsunny
Copy link
Collaborator

prsunny commented Mar 15, 2023

Merging the PR to proceed with implementation. Further comments can be addressed in a future PR.

@prsunny prsunny merged commit 40b7797 into sonic-net:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

@prsunny prsunny prsunny left review comments

@mhanif mhanif mhanif approved these changes

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

Assignees
No one assigned
Labels
None yet
Projects
DASH P4 Behavioral Model
Status: 🔬Scoping
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vijasrin @prsunny @KrisNey-MSFT @mhanif @lguohan