Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No output from "show vlan config" command when VLANs not assigned to interfaces #6606

Closed
Hedgehog-Guru opened this issue Jan 29, 2021 · 6 comments
Assignees

Comments

@Hedgehog-Guru
Copy link

Description
Command "show vlan config" not providing information about configured VLANs if no interface assigned to this VLANs

Steps to reproduce the issue

  1. Add two VLANs:
config vlan add 100
config vlan add 200
  1. Run command
show vlan config

Describe the results you received
Empty output received after command input:

Name    VID    Member    Mode
------  -----  --------  ------

Describe the results you expected
Expecting that command output will provide information about configured VLANs (for example):

Name    VID    Member    Mode
------  -----  --------  ------
VLAN100   100
VLAN200   200

Output of show version

SONiC Software Version: SONiC.SONIC.master.66-6957e37_Internal
Distribution: Debian 10.7
Kernel: 4.19.0-9-2-amd64
Build commit: 6957e376
Build date: Tue Jan 26 08:50:23 UTC 2021
Built by: sw-r2d2-bot@r-build-sonic-ci02

Platform: x86_64-mlnx_msn2100-r0
HwSKU: ACS-MSN2100
ASIC: mellanox
ASIC Count: 1
Serial Number: MT1708X00566
Uptime: 12:06:41 up 1 day,  1:19,  1 user,  load average: 4.90, 3.44, 2.94

Docker images:
REPOSITORY                    TAG                                IMAGE ID            SIZE
docker-syncd-mlnx             SONIC.master.66-6957e37_Internal   c0519f5f9216        539MB
docker-syncd-mlnx             latest                             c0519f5f9216        539MB
docker-teamd                  SONIC.master.66-6957e37_Internal   a36246281dba        405MB
docker-teamd                  latest                             a36246281dba        405MB
docker-nat                    SONIC.master.66-6957e37_Internal   5849ba798711        408MB
docker-nat                    latest                             5849ba798711        408MB
docker-platform-monitor       SONIC.master.66-6957e37_Internal   f6c7d6547805        684MB
docker-platform-monitor       latest                             f6c7d6547805        684MB
docker-orchagent              SONIC.master.66-6957e37_Internal   2e4d475fcbb4        423MB
docker-orchagent              latest                             2e4d475fcbb4        423MB
docker-macsec                 SONIC.master.66-6957e37_Internal   5aee04f2fded        408MB
docker-macsec                 latest                             5aee04f2fded        408MB
docker-dhcp-relay             SONIC.master.66-6957e37_Internal   fbdda1980695        401MB
docker-dhcp-relay             latest                             fbdda1980695        401MB
docker-fpm-frr                SONIC.master.66-6957e37_Internal   18a60a89ce13        423MB
docker-fpm-frr                latest                             18a60a89ce13        423MB
docker-sflow                  SONIC.master.66-6957e37_Internal   43a89650eb91        406MB
docker-sflow                  latest                             43a89650eb91        406MB
docker-snmp                   SONIC.master.66-6957e37_Internal   09cab211ff77        435MB
docker-snmp                   latest                             09cab211ff77        435MB
docker-sonic-mgmt-framework   SONIC.master.66-6957e37_Internal   f48021f6d2cc        612MB
docker-sonic-mgmt-framework   latest                             f48021f6d2cc        612MB
docker-router-advertiser      SONIC.master.66-6957e37_Internal   c3ffe156b7cd        394MB
docker-router-advertiser      latest                             c3ffe156b7cd        394MB
docker-lldp                   SONIC.master.66-6957e37_Internal   9a625f8b36e9        434MB
docker-lldp                   latest                             9a625f8b36e9        434MB
docker-database               SONIC.master.66-6957e37_Internal   d88f98696c3b        394MB
docker-database               latest                             d88f98696c3b        394MB
docker-sonic-telemetry        SONIC.master.66-6957e37_Internal   cdfcf055317a        469MB
docker-sonic-telemetry        latest                             cdfcf055317a        469MB

sonic_dump_r-qa-sw-eth-75_20210129_121528.tar.gz

@prsunny
Copy link
Contributor

prsunny commented Jan 29, 2021

@dawnbeauty, this is introduced by the PR-sonic-net/sonic-utilities#768. Could you take a look and fix?

@dprital
Copy link
Collaborator

dprital commented Feb 22, 2021

Hi, Any progress with this issue ?

@allas-nvidia
Copy link

Hi.
I see the problem. IMO we need to decide what should be the output of show vlan config even with "working" flow.
The current output is:

Name      VID  Member      Mode
------  -----  ----------  ------
Vlan77     77  Ethernet8   tagged
Vlan77     77  Ethernet16  tagged
Vlan77     77  Ethernet24  tagged

Do we need to repeat vlan77 for every member. Maybe its better to have:

Name      VID  Member      Mode
------  -----  ----------  ------
Vlan77     77  Ethernet8   tagged
               Ethernet16  tagged
               Ethernet24  tagged

Then, the question is:what is the difference between
show vlan config and show vlan brief

+-----------+--------------+------------+----------------+-----------------------+-------------+
|   VLAN ID | IP Address   | Ports      | Port Tagging   | DHCP Helper Address   | Proxy ARP   |
+===========+==============+============+================+=======================+=============+
|        77 |              | Ethernet8  | tagged         |                       | disabled    |
|           |              | Ethernet16 | tagged         |                       |             |
|           |              | Ethernet24 | tagged         |                       |             |
+-----------+--------------+------------+----------------+-----------------------+-------------+

Please let me know your opinion

@prsunny
Copy link
Contributor

prsunny commented Mar 11, 2021

@allas-nvidia , agree that it is redundant info, but currently i dont think we have a command to see what Vlan's are associated to an interface. But with this 'show vlan config | grep Ethernet0', we could get that info. So prefer to keep the existing output format. What do you think?

@allas-nvidia
Copy link

Ok, so I leave the current presentation + fix BUG :)

@Hedgehog-Guru
Copy link
Author

Issue fixed and not observed in the image:

SONiC Software Version: SONiC.SONIC.202012.56-23c7940_Internal
Distribution: Debian 10.9
Kernel: 4.19.0-12-2-amd64
Build commit: 23c79407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants