fwutil update all CLI feedback does not match HLD

[alexrallen]

Description

The CLI feedback from fwutil update all is not very human-readable and makes debugging difficult. It also does not match the format specified in the CLI.

Steps to reproduce the issue:

1. Setup platform_components.json

{
    "chassis": {
        "MSN2410": {
            "component": {
                "ONIE": {                },
                "SSD": {                },
                "BIOS": { },
                "CPLD1": {                         
                        "firmware": "/lib/firmware/CPLD_older.mpfa"
                },
                "CPLD2": { 
                        "firmware": "/lib/firmware/CPLD_older.mpfa"
                },
                "CPLD3": {
                        "firmware": "/lib/firmware/CPLD_older.mpfa"
                }
            }
        }
    }
}

2. Run fwutil update all fw --boot=cold

Describe the results you received:

root@r-qa-sw-eth-21101:/home/admin# fwutil update all fw --boot=cold
Firmware auto-update for boot_type cold is allowed
MSN2410/CPLD1 firmware auto-update starting: /lib/firmware/CPLD_older.mpfa with boot_type cold
ERROR: Extend name of file /lib/firmware/CPLD_older.mpfa is wrong. Image for CPLD1 should have extend name .vme
MSN2410/CPLD1 firmware auto-update status return_code: -3
MSN2410/CPLD3 firmware auto-update starting: /lib/firmware/CPLD_older.mpfa with boot_type cold
ERROR: Extend name of file /lib/firmware/CPLD_older.mpfa is wrong. Image for CPLD3 should have extend name .vme
MSN2410/CPLD3 firmware auto-update status return_code: -3
Warning: All firmware auto-update has been performed.
All firmware auto-update has been performed
root@r-qa-sw-eth-21101:/home/admin# 

Numerical return codes are given rather than human-readable feedback. Suggest returning the return_code ENUM value at a minimum, human readable text preferred.

Describe the results you expected:

root@sonic:~# fwutil update all fw --yes --image=next --boot=fast
Firmware auto-update for boot_type fast is allowed
MSN2700/BIOS firmware auto-update starting: /lib/firmware/mlnx/bios.bin with fast
...
BIOS firmware auto-update status from 0ACLH004_02.02.007 to 0ACLH004_02.02.010: updated - completed
...
MSN2700/SSD firmware auto-update starting: /lib/firmware/mlnx/ssd.bin with fast
...
SSD firmware auto-update status from 4 to 5: scheduled - installation scheduled for fast reboot
...
MSN2700/CPLD firmware auto-update starting: /lib/firware/mlnx/cpld.bin with fast
...
CPLD firmware auto-update status from 5 to 10: skipped - warm reboot not supported for auto-update
All firmware auto-update has been performed.

Results described in the HLD here: https://github.com/Azure/SONiC/blob/master/doc/fwutil/fwutil.md#22241-overview

[dgsudharsan]

@sujinmkang FYI

[zhangyanzhao]

@sujinmkang can you please help to provide an update? Thanks.