Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[switchorch]:support changing mac aging time dynamically. #352

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

gongjianLhr
Copy link
Contributor

Signed-off-by: Haoran Liu [email protected]

Add codes in switchorch to support changing mac aging time dynamically

@lguohan
Copy link
Contributor

lguohan commented Oct 17, 2017

@gongjianLhr , do you have test for mac aging feature?

@gongjianLhr
Copy link
Contributor Author

Hi lguohan @lguohan this pull request is only about the consumer side of setting the mac aging time(reading from APP_DB). The cli (writing to CONFIG_DB) and the enforcer(reading from CONFIG_DB and writing to APP_DB) are still absent.
I have developed the cli and tested it in our lab.
But the enforcer is based on liuqu's pull request of hostCFGD of aaa cli.
Since you haven't accept the hostCFGD design. It just blocked me from pulling the cli of setting mac aging time.
Considing that there is no cli to set the mac aging time, there is no way to test it.
So should I wait for liuqu's pull request to be accepted ? Or you accept without test and later I add the test after the hostCFGD is accessiable?

@lguohan lguohan merged commit 2adb21a into sonic-net:master Nov 29, 2017
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
* [syncd] delay creating diag shell to after switch is created

Signed-off-by: Ying Xie <[email protected]>

* [syncd] provide default SAI warmboot data file in case not specified

Signed-off-by: Ying Xie <[email protected]>

* [syncd] move performWarmRestart to sycnd_hard_reinit.cpp

- Move function to get access to static local variables.
- Improve the function according to the new SAI interaction requirements.
- Remove 'TODO' and exception since the code is now working.

Signed-off-by: Ying Xie <[email protected]>

* [syncd] restore previously changed warm boot condition

Signed-off-by: Ying Xie <[email protected]>

* [syncd script] refactor syncd init script

- move start type setting in a helper function

Signed-off-by: Ying Xie <[email protected]>

* [syncd script] check and set warm start type

WARM start takes precedence over fast start. Because fast boot option
is a kernel command line option. This option will always be there
after a fast reboot.

Signed-off-by: Ying Xie <[email protected]>

* [syncd] comment out warm start option calculation for now

redis-cli is not available in syncd docker. Some work/discussion/decision
is required if we want to continue start option.

Signed-off-by: Ying Xie <[email protected]>

* [syncd] take warm boot hint from database directly

Signed-off-by: Ying Xie <[email protected]>
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023
…cation id (sonic-net#352)

* Retrieve channel from CONFIG_DB to enable breakout support

Signed-off-by: Mihir Patel <[email protected]>

* Enhanced test_get_host_lane_assignment_option

* Resolved test case failure

* Addressed review comments

---------

Signed-off-by: Mihir Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants