EPIC: Version 2.0

[soofstad]

A list of some things that can be done and included in a 2.0 release. Some are breaking, some are not. Most are up for discussion.

• No auto redirect during session
• Remove renamed/unused parameters
• Require onRefreshTokenExpire()
• Require handleRefreshError() - maybe(?)
• Rethink AuthContext interface (isAuthenticated, isLoading, etc.)
• Check for using Context outside of Provider
• Offer a useAuthContext() - (?)
• No/reduce usage of positional arguments (ex. logIn(undefine, undefine, True))

[github-actions]

Stale issue message

[dburles]

+1 for auth context API outside of react, primarily token information.

[sebastianvitterso]

I don't like that we sometimes have to recommend users to write stuff like logIn(undefined, undefined, 'popup'). Not a fan of the undefineds there. I propose for v2:

So

type LoginConfig = {
  state?: string
  additionalParameters?: TPrimitiveRecord
  method?: 'redirect' | 'popup' | 'replaced-redirect'
}

function logIn (config?: LoginConfig) {}

[soofstad]

@dburles
Could you specify what you mean by "auth context API outside of react"?
ReactContext is the only API we have now. Not sure what other API's you'd need in a React package

[dburles]

@soofstad I have data fetching logic that lives outside of React context which relies on the access token. Currently to get the token I am grabbing it directly from local storage, which works, but feels like a bit of a hack.