Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinIO bundled chart does not support Ingress networking.k8s.io/v1 #186

Open
boomaker opened this issue Dec 5, 2022 · 2 comments
Open

MinIO bundled chart does not support Ingress networking.k8s.io/v1 #186

boomaker opened this issue Dec 5, 2022 · 2 comments

Comments

@boomaker
Copy link

boomaker commented Dec 5, 2022

Summary

Sorry cypress Helm chart bundles MinIO v8.0.9 which does not support Ingresses version networking.k8s.io/v1 for Kubernetes 1.24+

This is caused by the following block in the MinIO _helpers.tpl:

{{/*
Return the appropriate apiVersion for ingress.
*/}}
{{- define "minio.ingress.apiVersion" -}}
{{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.GitVersion -}}
{{- print "extensions/v1beta1" -}}
{{- else -}}
{{- print "networking.k8s.io/v1beta1" -}}
{{- end -}}
{{- end -}}

Environment

  • sorry-cypress version: 2.4.2
  • cypress version: various
  • helm chart version: 1.7.10
@boomaker boomaker changed the title MinIO bundle chart does not support Ingress networking.k8s.io/v1 MinIO bundled chart does not support Ingress networking.k8s.io/v1 Dec 5, 2022
@boomaker
Copy link
Author

boomaker commented Dec 8, 2022

I can patch the MinIO _helpers.tpl and create a PR with the new .tgz but I'm not convinced it's a good practice.
WDYT?

@phoenix-henri
Copy link

I think the chart needs to update the dependencies and use the new minio chart, that should solve the issues "permanently" and in a more "best-practice" oriented manner...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants