Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global domain settings #1

Closed
ghost opened this issue Jan 23, 2018 · 4 comments
Closed

global domain settings #1

ghost opened this issue Jan 23, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Jan 23, 2018

Thank you for this extension!

I was trying to set a global approach with the wildcard but either way I tried it did not work.

1 host * (global) / a-l FR (as an example)
2 host *.uk (localized) / a-l GB

In this scenario (1) takes precedence over everything and (2) is not applied. Alternatively tried

1 host *.* (global) / a-l FR
2 host *.uk (localized) / a-l GB

In this scenario (1) is not applied at any domain/host but only (2)

@sorz
Copy link
Owner

sorz commented Jan 23, 2018

The global languages can be set on about:preferences.

Match patterns are directly passed to the browser's API: wildcard can only be the beginning and followed by a dot, so *.* won't work.

I didn't consider the scenario when rules are overlapping. Did you try change the order of rules?

@ghost
Copy link
Author

ghost commented Jan 23, 2018

My point of using this extension is to escape browser sniffing with the NavigatorLanguage.language API
This API is overriding the header and thus I hope that with the other browser extension the API can be stopped and the header becoming the sole source of language information.

Hence I was looking for a global setting and then to cascade localized settings whenever needed.

Yes, tested the order of rules but * takes always precedence, whether top or bottom of the order. I had hoped for a logic of weighing the specifics of the domain declaration, e.g. *.uk is more specific than * and thus *.uk takes precedence over *

@sorz
Copy link
Owner

sorz commented Jan 23, 2018

I see.
It's possible but requires change the extension to intercept all requests and implement rule matching by ourself. I will look into it later.

@sorz sorz closed this as completed in 5b55220 Jan 23, 2018
@ghost
Copy link
Author

ghost commented Jan 24, 2018

Just a quick thank you for the instant patch! Love it and rated it already 5* at AMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant