This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Fix missing data-x-out-of-boundaries attribute #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
No support for https://popper.js.org/popper-documentation.html#modifiers..hide.
Expected behavior
Full support for
modifiers.hide
, specifically that thedata-x-out-of-boundaries
attribute is passed along.Changes
Passes along the
data-x-out-of-boundaries
attribute in a similar manner todata-placement
.Why
We needed this in our app. More importantly, we saw no reason a wrapper around Popper shouldn’t support this.
How this has been tested
Confirmed
build
still works. Confirmed expected example behavior when runningdev
after modifying the Popper config like so: