Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourcegraph/sourcegraph#33161: "hackathon - search/notebook: basic end-to-end notebook result rendering" #142

Closed
sourcegraph-bot opened this issue Mar 29, 2022 · 2 comments
Closed

sourcegraph/sourcegraph#33161: "hackathon - search/notebook: basic end-to-end notebook result rendering" #142

sourcegraph-bot opened this issue Mar 29, 2022 · 2 comments
Assignees
@tsenart
Labels
approved Signals that this issue has been reviewed and approved. exception/test-plan sourcegraph/sourcegraph

Comments

@sourcegraph-bot
Copy link

https://github.com/sourcegraph/sourcegraph/pull/33161 "hackathon - search/notebook: basic end-to-end notebook result rendering" has no test plan.

Learn more about test plans in our testing guidelines.

@tsenart please comment in this issue with an explanation for this exception and close this issue.
@tsenart
Copy link

tsenart commented Mar 29, 2022

This is a feature branch, not in main. cc @sourcegraph/dev-experience this shouldn't apply to merges to feature branches.

@tsenart tsenart closed this as completed Mar 29, 2022
@bobheadxi bobheadxi mentioned this issue Mar 30, 2022
Merged
@bobheadxi
Copy link
Member

Sorry about that! Fixed in https://github.com/sourcegraph/sourcegraph/pull/33201

@jhchabran jhchabran added the approved Signals that this issue has been reviewed and approved. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsenart tsenart

Labels
approved Signals that this issue has been reviewed and approved. exception/test-plan sourcegraph/sourcegraph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jhchabran @tsenart @sourcegraph-bot @bobheadxi