-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sig collect
should resolve to individual files when loading a pathlist or a directory
#3039
Comments
sig collect
should do resolve to individual files when loading a pathlist or a directorysig collect
should resolve to individual files when loading a pathlist or a directory
the challenge is that we don't want to override the location for when it is, in fact, not something directly resolvable - like when the or, to frame it in the terms @luizirber proposed over in #3008 (comment): we probably want to resolve to individual files when loading things from a file system storage, but not from a zip storage. |
perhaps a different way do this is to allow Index classes to specify whether their locations are resolvable at the file system level or not? |
alternatively, support a different 'location' which is 'lowest possible file system resolvable path'... |
acshually... I think we should just advise people not to use pathlists and directories, and instead have them use I don't think we should complicate the |
suppose you have a pathlist containing a bunch of zip files, and you run
sig collect
directly on the pathlist:you end up with a manifest CSV file that has
podar-ref-zip-list.txt
for all of theinternal_location
values.if, instead, you do:
you end up with the individual files going into the
internal_location
values, which is preferable.this is because
sig collect
overwrites the "true" location of sketches with the location they were loaded from on the command line. This is appropriate in many other situations but is not great when loading from directories or pathlists or (I suspect) standalone manifests.related issues:
The text was updated successfully, but these errors were encountered: