Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what query and against types does manysearch actually support? #232

Closed
ctb opened this issue Feb 20, 2024 · 8 comments
Closed

what query and against types does manysearch actually support? #232

ctb opened this issue Feb 20, 2024 · 8 comments

Comments

@ctb
Copy link
Collaborator

ctb commented Feb 20, 2024

running into problems using zip files as queries, and other things. need to look into this!

@bluegenes
Copy link
Contributor

bluegenes commented Feb 20, 2024

Might this be another zip internal_location issue? sourmash-bio/sourmash#3009

In load_sketches, I used it as the location of the sig. But, the minhash should be loaded properly from the zip...

sketchinfo.push(SmallSignature {
                    location: record.internal_location().to_string(),
                    name: sig.name(),
                    md5sum: sig.md5sum(),
                    minhash,
                })

@ctb
Copy link
Collaborator Author

ctb commented Feb 20, 2024

I poked around a bit and I absolutely do not understand what is going on 😆 . So, you know, please hold...

@ctb
Copy link
Collaborator Author

ctb commented Feb 20, 2024

it looks like my podar-ref.zip file is wonky in some way. Digging.

@ctb
Copy link
Collaborator Author

ctb commented Feb 20, 2024

ah-hah! it looks like zip files must contain a manifest, and if they don't, branchwater barfs and tries to read it as a pathlist or something.

@bluegenes
Copy link
Contributor

ah-hah! it looks like zip files must contain a manifest, and if they don't, branchwater barfs and tries to read it as a pathlist or something.

this makes sense. I just assumed all zips would have manifests and didn't do any special handling otherwise.

@ctb
Copy link
Collaborator Author

ctb commented Feb 24, 2024

spent some time tracking this down over in #237 - looks like zip files cannot be loaded from either pathlists or manifests.

@ctb
Copy link
Collaborator Author

ctb commented Feb 24, 2024

we might also want to support traversing zip files without manifests. Or (probably better!) more politely erroring out if zip files don't contain a manifest.

@ctb
Copy link
Collaborator Author

ctb commented Mar 5, 2024

closing in favor of #264 and #266

@ctb ctb closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants