Removing call to image_id_matches in load_current_resource #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2014
|
I've merged in #157 which may resolve this issue and am going to preemptively close #139, #153, and #154 even though they may not be fully resolved yet. I'd prefer if someone created separate new single issues to track if you are:
Thanks so much for your cooperation and patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking the call to
image_id_matches?in the image LWRP'sload_current_resourcemethod solves the problem that I was having in #153. I'm not positive, but it looks like new_resource.id is always nil at the time that load_current_resource is called.