Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker deregistration after connector shutdown seems not to work properly #266

Closed
ip312 opened this issue Apr 6, 2023 · 7 comments
Closed
Labels
kind/bug Something isn't working. The software does not behave as expected or specified.

Comments

@ip312
Copy link

ip312 commented Apr 6, 2023

Bug Report

Description

After shutdown of the connector I can further see it on the MDS test broker.
https://catalog.test.mobility-dataspace.eu/connector/connector?id=https%3A%2F%2Fbroker.test.mobility-dataspace.eu%2Fcatalog%2F457711283

Expected Behavior

After shutdown the connector is not visible on the broker anymore.

Observed Behavior

It is visible.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start the local connector in the docker desktop
  2. Check, whether the connector is registered on the broker (yes)
  3. Shutdown the connector in the docker desktop
  4. Check, whether the connector is deregistered (no)

Context Information

  • Environment: Local
  • Used version: 3.0.1
@ip312 ip312 added the kind/bug Something isn't working. The software does not behave as expected or specified. label Apr 6, 2023
@ip312 ip312 changed the title Broker deregistration after connector shutdown seens not to work properly Broker deregistration after connector shutdown seems not to work properly Apr 6, 2023
@tmberthold
Copy link
Contributor

tmberthold commented Apr 13, 2023

Update
Test-Broker seems to currently not respond at all to IDS Messages-> getting 504 Gateway Timeout as response on messages to the IDS-endpoint https://broker.test.mobility-dataspace.eu/infrastructure

We'll keep looking at this...

@tmberthold tmberthold removed the kind/bug Something isn't working. The software does not behave as expected or specified. label Apr 13, 2023
@SebastianOpriel
Copy link
Member

@ip312 can you clarify on your latest observations regarding the Broker? Does this correlate with this issue?

@SebastianOpriel SebastianOpriel added task/analyze Need for investigation and removed analyze labels Apr 18, 2023
@ip312
Copy link
Author

ip312 commented Apr 18, 2023

My assumption is that there are two different things.
At the time i noticed the issue above I was able to register connectors, e.g.
https://catalog.test.mobility-dataspace.eu/connector/connector?id=https%3A%2F%2Fbroker.test.mobility-dataspace.eu%2Fcatalog%2F457711283
https://catalog.test.mobility-dataspace.eu/connector/connector?id=https%3A%2F%2Fbroker.test.mobility-dataspace.eu%2Fcatalog%2F-1765550025
https://catalog.test.mobility-dataspace.eu/connector/connector?id=https%3A%2F%2Fbroker.test.mobility-dataspace.eu%2Fcatalog%2F-1865489203
which were not deregistered after shutdown of these connectors in the docker desktop.

Currently I am not able to register connectors due to the mentioned response problem at the Broker. Also we should wait until the broker is up and running again.

@ip312
Copy link
Author

ip312 commented Apr 19, 2023

Now I can confirm the issue. I have just started the docker desktop and registered this connector
https://catalog.test.mobility-dataspace.eu/connector/connector?id=https%3A%2F%2Fbroker.test.mobility-dataspace.eu%2Fcatalog%2F457711283
After that I have stopped the docker container via docker desktop, but as you can see, the connector is still registered.

@SebastianOpriel SebastianOpriel added the kind/bug Something isn't working. The software does not behave as expected or specified. label May 2, 2023
@SebastianOpriel
Copy link
Member

SebastianOpriel commented May 2, 2023

@ip312 wrote:

The deregistration problem seems to be still there. Started the 3.1.0. version now, the connector reported to the broker, now I stopped that, but it is still there. https://catalog.test.mobility-dataspace.eu/connector/connector?id=https%3A%2F%2Fbroker.test.mobility-dataspace.eu%2Fcatalog%2F457711283 .
Branch 3.1.0 is missing, so I took main

  • Create branch 3.1.0

@SebastianOpriel
Copy link
Member

I could reproduce the issue.
docker compose up with CTL + C gracefully stopps the containers, but edc-extensions exits with code 137

Tried instead:

docker compose up -d
docker compose stop -t 100

But still runs into timeout of 100 sec.

@SebastianOpriel SebastianOpriel removed the task/analyze Need for investigation label May 22, 2023
@ip312
Copy link
Author

ip312 commented Jul 19, 2023

I think, this one can be closed. It's not relevant anymore.

@ip312 ip312 closed this as completed Jul 19, 2023
ununhexium pushed a commit that referenced this issue May 2, 2024
…-ts (#266)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.21...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
richardtreier added a commit that referenced this issue Feb 24, 2025
* fix long single words breaking card titles

* feat re-add consuming contract agreements section header

* feat add asset propreties as titles

* chore update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working. The software does not behave as expected or specified.
Projects
None yet
Development

No branches or pull requests

3 participants