Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Documentation on Asset creation #321

Closed
nilutz opened this issue May 10, 2023 · 0 comments
Closed

More Documentation on Asset creation #321

nilutz opened this issue May 10, 2023 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@nilutz
Copy link

nilutz commented May 10, 2023

Feature Request

More Documentation on Asset creation

Description

In a current use case we want to use an Asset and set its dataAddress to allow proxyQueryParams. As an example consider the following, our Asset has a baseUrl of https://example.com and the user can use queryParams to request different underlying data like so: https://example.com?query=hello&id=123. The question now arises how the assets in EDC would support such a behaviour. After some research we found out that one can enable flags to enable certain behaviour on producer side. So in order to create an asset, one would need to enable proxyQueryParams like so:

    "dataAddress": {
        "properties": {
            "type": "HttpData",
            "baseUrl": "https://example.com",
            "method": "GET",
            "proxyQueryParams":True,
        }
    }

But how would the consumer now tell the producer which params to proxy to the dataAdress baseUrl ? I tried with the following request data:

"dataDestination": {
    "properties": {
      "type": "HttpData",
      "baseUrl": https://destination-url.com,
      "assetId": "asset-id-123",
    },
  },
  "properties" : {
    "queryParams":  {
        "query":"hello",
        "id":123
    }
}

But had no luck. In addition the documentation or openapi.yaml has no information on what could go into the "properties" section on how to control the "dataAdress" or "dataDestination" behaviour.

Why Is the Feature Desired?

In order to for developers to use the EDC to hook up any data source this part of the documentation is crucial

@nilutz nilutz added the kind/enhancement New feature or request label May 10, 2023
@sovity sovity locked and limited conversation to collaborators May 10, 2023
@SebastianOpriel SebastianOpriel converted this issue into discussion #323 May 10, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant