-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rework lastcommitinfo extension #319
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary) (#309) * feat oauth2 client credentials auth flow (Java API Wrapper Client Library) * fix README.md (Java API Wrapper Client) * refactor remove google oauth dependency, minor code quality improvements * ci add retries due to iais maven repo issue * fix minor code quality issues
* build(deps): bump io.quarkus from 2.16.6.Final to 3.0.2.Final Bumps io.quarkus from 2.16.6.Final to 3.0.2.Final. --- updated-dependencies: - dependency-name: io.quarkus dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump io.quarkus.platform:quarkus-bom (#313) Bumps [io.quarkus.platform:quarkus-bom](https://github.com/quarkusio/quarkus-platform) from 2.16.6.Final to 3.0.2.Final. - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.16.6.Final...3.0.2.Final) --- updated-dependencies: - dependency-name: io.quarkus.platform:quarkus-bom dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump io.quarkus.platform:quarkus-bom (#313) Bumps [io.quarkus.platform:quarkus-bom](https://github.com/quarkusio/quarkus-platform) from 2.16.6.Final to 3.0.2.Final. - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.16.6.Final...3.0.2.Final) --- updated-dependencies: - dependency-name: io.quarkus.platform:quarkus-bom dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tim Berthold <[email protected]>
richardtreier
requested changes
May 8, 2023
extensions/last-commit-info/src/main/java/de/sovity/edc/extension/LastCommitInfo.java
Outdated
Show resolved
Hide resolved
extensions/last-commit-info/src/main/java/de/sovity/edc/extension/LastCommitInfoService.java
Outdated
Show resolved
Hide resolved
extensions/last-commit-info/src/main/java/de/sovity/edc/extension/LastCommitInfoService.java
Outdated
Show resolved
Hide resolved
extensions/last-commit-info/src/main/java/de/sovity/edc/extension/LastCommitInfoService.java
Outdated
Show resolved
Hide resolved
...commit-info/src/test/java/de/sovity/edc/extension/version/controller/LastCommitInfoTest.java
Outdated
Show resolved
Hide resolved
richardtreier
requested changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing tests, etc.
richardtreier
requested changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming inconsistency
...commit-info/src/test/java/de/sovity/edc/extension/version/controller/LastCommitInfoTest.java
Outdated
Show resolved
Hide resolved
richardtreier
requested changes
May 9, 2023
extensions/last-commit-info/src/test/resources/jar-last-build-date-info.txt
Outdated
Show resolved
Hide resolved
...commit-info/src/test/java/de/sovity/edc/extension/version/controller/LastCommitInfoTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Converted last commit information from string to JSON
PR is blocked by
Checklist