Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rework lastcommitinfo extension #319

Closed
wants to merge 11 commits into from

Conversation

AnurosePrakash
Copy link
Contributor

@AnurosePrakash AnurosePrakash commented May 5, 2023

Pull Request

Converted last commit information from string to JSON

PR is blocked by

Checklist

  • I have formatted the title correctly and precisely
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and public classes/methods
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (performed checkstyle check locally)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have added/updated copyright headers

@AnurosePrakash AnurosePrakash marked this pull request as draft May 5, 2023 10:30
@AnurosePrakash AnurosePrakash marked this pull request as ready for review May 5, 2023 11:25
@richardtreier richardtreier marked this pull request as draft May 5, 2023 13:57
AnurosePrakash and others added 4 commits May 8, 2023 15:33
…rary) (#309)

* feat oauth2 client credentials auth flow (Java API Wrapper Client Library)

* fix README.md (Java API Wrapper Client)

* refactor remove google oauth dependency, minor code quality improvements

* ci add retries due to iais maven repo issue

* fix minor code quality issues
* build(deps): bump io.quarkus from 2.16.6.Final to 3.0.2.Final

Bumps io.quarkus from 2.16.6.Final to 3.0.2.Final.

---
updated-dependencies:
- dependency-name: io.quarkus
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump io.quarkus.platform:quarkus-bom (#313)

Bumps [io.quarkus.platform:quarkus-bom](https://github.com/quarkusio/quarkus-platform) from 2.16.6.Final to 3.0.2.Final.
- [Release notes](https://github.com/quarkusio/quarkus-platform/releases)
- [Commits](quarkusio/quarkus-platform@2.16.6.Final...3.0.2.Final)

---
updated-dependencies:
- dependency-name: io.quarkus.platform:quarkus-bom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump io.quarkus.platform:quarkus-bom (#313)

Bumps [io.quarkus.platform:quarkus-bom](https://github.com/quarkusio/quarkus-platform) from 2.16.6.Final to 3.0.2.Final.
- [Release notes](https://github.com/quarkusio/quarkus-platform/releases)
- [Commits](quarkusio/quarkus-platform@2.16.6.Final...3.0.2.Final)

---
updated-dependencies:
- dependency-name: io.quarkus.platform:quarkus-bom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tim Berthold <[email protected]>
@AnurosePrakash AnurosePrakash marked this pull request as ready for review May 8, 2023 13:44
@AnurosePrakash AnurosePrakash marked this pull request as draft May 8, 2023 14:06
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing tests, etc.

@AnurosePrakash AnurosePrakash self-assigned this May 9, 2023
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming inconsistency

@AnurosePrakash AnurosePrakash deleted the feat/rework_lastcommitinfo_extension branch May 31, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants