Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer history model #359

Merged
merged 8 commits into from
May 31, 2023
Merged

Transfer history model #359

merged 8 commits into from
May 31, 2023

Conversation

AnurosePrakash
Copy link
Contributor

@AnurosePrakash AnurosePrakash commented May 31, 2023 •
edited
Loading

Pull Request

Describing the transfer history model

PR is blocked by

Checklist

  • I have formatted the title correctly and precisely
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and public classes/methods
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (performed checkstyle check locally)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have added/updated copyright headers

AnurosePrakash and others added 6 commits May 31, 2023 12:57
@AnurosePrakash
feat: Adding Transfer History Page Model(WIP)
64d5cba
@AnurosePrakash
feat: Adding Transfer History Page Model
bfc00ad
@AnurosePrakash
feat: updated data model of transfer
aaee0e5 
entry page
@AnurosePrakash
chore: renamed data model of transfer
83ccf52 
entry page
@AnurosePrakash @richardtreier
feat: build dates for LastCommitInfoExtension (#357)
5b12de4 
* feat: Reworking Last commit Info Extension

* chore: make pipeline set both jar and env build date and last commit info, fix wording

* Updated CHANGELOG.md

---------

Co-authored-by: Richard Treier <[email protected]>
@AnurosePrakash
Merge remote-tracking branch 'origin/main'
792d831
@AnurosePrakash AnurosePrakash self-assigned this May 31, 2023
richardtreier
richardtreier requested changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing the changes in the UiResource, we need a transferHistoryPage GET endpoint

@AnurosePrakash AnurosePrakash mentioned this pull request May 31, 2023
Closed
11 tasks
richardtreier
richardtreier approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardtreier richardtreier merged commit 438e193 into main May 31, 2023
@richardtreier richardtreier deleted the transfer_history_model branch May 31, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier richardtreier approved these changes

Assignees

@AnurosePrakash AnurosePrakash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnurosePrakash @richardtreier