Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulating christmas gifts indicates heating can be initially unlocked without matches #1037

Open
itsGreyGhost opened this issue Jan 6, 2025 · 5 comments
Labels
bug Something isn't working fixed
Milestone

Comments

@itsGreyGhost
Copy link

SPT Version

4.0

Project Type

Modules

Expected Result

Transfering christmas gifts to stash from a raid doesn't let you upgrade heating (initial unlock).

Actual Result

Transfering christmas gifts after a raid gives me the notification that heating is ready for upgrade. I hopped into the hideout and heating was green saying I had 2 box matches in my stash when I didn't and it was upgradable to level 1.

Note: I did not actually upgrade heating because i wanted to see if the gifts contained matches causing heating to be allowed to be upgraded so I opened the gifts and none of them had matches in them. When I do open the gifts, heating is no longer upgradable.

Steps To Reproduce

Collect christmas gifts. It's not just one or two though. Both times when I saw this happen I had accumulated about 4-5 gifts (unopened) from multiple raids.

Server Log

server-2025-01-06.log

BepinEx Log

LogOutput.log

Client Log

2025.01.06_20-23-32_0.16.0.2.34510 traces.log

Player Profile

677bed6e0005007c747f32c4.json

Screenshots

No response

@itsGreyGhost itsGreyGhost added the triage New issue. Who dis? label Jan 6, 2025
@itsGreyGhost
Copy link
Author

Happened again except with the lavatory this time, grabbed a couple gifts in raid, transferred them to my stash and only the 2 gifts got transferred over (3 gifts in total in my inventory at this point). I got a notification that the lavatory was available for upgrade but this time I proceeded to upgrade. It worked fine and the gifts remained in tact in the stash.

@chompDev chompDev added needs-investigation and removed triage New issue. Who dis? labels Jan 7, 2025
@chompDev chompDev added this to the 4.0.0 milestone Jan 7, 2025
@chompDev
Copy link
Contributor

chompDev commented Jan 8, 2025

Do you have the items to upgrade the hideout areas prior to getting the gifts?
I am wondering if the act of moving the gifts to your stash triggers the popup to show

@itsGreyGhost
Copy link
Author

itsGreyGhost commented Jan 8, 2025

I did not have the items in the inventory. In fact, I have it in a state where heating is upgradable without me having 2x classic matches right now.
677bed6e0005007c747f32c4-packedgifts.json

I should clarify, this is the 2nd time heating was ready for construction with christmas gifts. First time, I unpacked the gifts to see they contained the matches which they didn't. This time around, I left them as is so it can be investigated.

@DrakiaXYZ
Copy link
Contributor

The issue appears to be that the gifts are generated containing child items, but those items are ignored when opening it and new loot is generated instead.

The gifts containing matches is what's triggering the notification, but when you open it new random items are generated, so you don't actually get the matches the gift thought it contained

@chompDev
Copy link
Contributor

chompDev commented Jan 8, 2025

Fixed with: 33591df

@chompDev chompDev added bug Something isn't working fixed and removed needs-investigation labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

3 participants