-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Sidenav to cover all the space #16
Comments
Yes, it's OK to leave as-is if it seems like a lot of work. A related thing is that the hamburger sometimes doesn't show up because of the background image color (black on black). Any way to adapt to the background image color? |
While the sidenav width can be changed on mobile views, the button position is problematic. Given the way the icon is built, it will be very complicated to come up with a solution for it to look good in this case. I think the width can be left as it currently is. PR mjeronimo/pelican-fh5co-marble#6 solves it's color issue. Let me know what do you think @mjeronimo |
Sounds good to me. We can close this one. |
mjeronimo/pelican-fh5co-marble#6 has been merged. I'll proceed to close this one! |
Related to #6
Make the sidenav as wide as the screen on Mobile devices.
Check the feasibility of this:
In case it is very difficult to implement this in the current theme, perhaps it's a good idea to leave the current behavior. FYI @mjeronimo . I'll let you know how this goes.
The text was updated successfully, but these errors were encountered: