Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Sidenav to cover all the space #16

Closed
german-e-mas opened this issue Dec 7, 2022 · 4 comments
Closed

[Mobile] Sidenav to cover all the space #16

german-e-mas opened this issue Dec 7, 2022 · 4 comments
Assignees

Comments

@german-e-mas
Copy link
Contributor

Related to #6

Make the sidenav as wide as the screen on Mobile devices.

Check the feasibility of this:

  • The hamburguer icon should transform to a cancel and be on top of the expanded sidenav as well.
  • We shouldn't be able to scroll horizontally while the sidenav is open. It should be an overlay.

In case it is very difficult to implement this in the current theme, perhaps it's a good idea to leave the current behavior. FYI @mjeronimo . I'll let you know how this goes.

@german-e-mas german-e-mas self-assigned this Dec 7, 2022
@mjeronimo
Copy link

Yes, it's OK to leave as-is if it seems like a lot of work. A related thing is that the hamburger sometimes doesn't show up because of the background image color (black on black). Any way to adapt to the background image color?

@german-e-mas
Copy link
Contributor Author

While the sidenav width can be changed on mobile views, the button position is problematic.

spaceROS-toggle-btn-003

Given the way the icon is built, it will be very complicated to come up with a solution for it to look good in this case.

I think the width can be left as it currently is. PR mjeronimo/pelican-fh5co-marble#6 solves it's color issue.

Let me know what do you think @mjeronimo

@mjeronimo
Copy link

Sounds good to me. We can close this one.

@german-e-mas
Copy link
Contributor Author

mjeronimo/pelican-fh5co-marble#6 has been merged. I'll proceed to close this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants