Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News reports with [] Crash PDAs when reading them. #30152

Closed
Titian3 opened this issue Jul 18, 2024 · 1 comment · Fixed by #30169
Closed

News reports with [] Crash PDAs when reading them. #30152

Titian3 opened this issue Jul 18, 2024 · 1 comment · Fixed by #30169
Labels
S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.

Comments

@Titian3
Copy link
Member

Titian3 commented Jul 18, 2024

Description

When a news article is written with [] in it, when the PDA attempts to open the article it the parser breaks and the PDA glitches out.

Reproduction

  • Make article, See last image for replication text.
  • Open article in news reader app on the PDA
  • PDA window glitches and rendering seems to flicker.

Screenshots
image

image
image
image

Additional context
I swore I had made another one of these but not sure where it went and I didn't have a replication.
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Jul 18, 2024
@Tayrtahn
Copy link
Member

I'm pretty sure this can be fixed by changing this line to use SetMarkupPermissive:

https://github.com/space-wizards/space-station-14/blob/master/Content.Client%2FCartridgeLoader%2FCartridges%2FNewsReaderUiFragment.xaml.cs#L34

@1337Dakota 1337Dakota mentioned this issue Jul 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Markup Tags in Station News 1337Dakota/space-station-14
2 participants
@Tayrtahn @Titian3