Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thief beacon double counts items in nested containers #31337

Closed
deltanedas opened this issue Aug 23, 2024 · 6 comments · Fixed by #33750
Closed

thief beacon double counts items in nested containers #31337

deltanedas opened this issue Aug 23, 2024 · 6 comments · Fixed by #33750
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes

Comments

@deltanedas
Copy link
Contributor

Description

  • stamp in a coat in a bag on a player, counts as 3
  • stamp in a storage implant in an implants container on a player, counts as 3

05:29:30

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Aug 23, 2024
@slarticodefast slarticodefast added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 29, 2024
@sporkyz
Copy link
Contributor

sporkyz commented Oct 12, 2024

Notably, this bug allows the thief to win the relevant sub-objective at round end; it's not just a visual issue with the character menu.

@sporkyz
Copy link
Contributor

sporkyz commented Oct 12, 2024

There appear to be two sperate issues with the beacon.

First, it double counts items in containers:
image
Second, it counts items in the user's inventories again if they're within the stealArea of the beacon:
image

If both of these problems happen at once (i.e., items stored within a bag, in the player's inventory, next to the beacon), both problems will compound and you'll get a triple-count:
image

@deltanedas
Copy link
Contributor Author

inventory is a container so that's to be expected

also i never said this was visual you can basically dupe items for the purpose of greentext

@sporkyz
Copy link
Contributor

sporkyz commented Oct 12, 2024

also i never said this was visual you can basically dupe items for the purpose of greentext

Yeah, didn't mean to imply you had. I'm mostly just documenting specifics because I'm working on a fix at the moment.

@lzk228
Copy link
Contributor

lzk228 commented Oct 12, 2024

can you make it quadriple with putting stamp in cig pack, cig pack in a box, a box in a backpack and then backpack on a player?

@deltanedas
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants