Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borgs don't get names on roundstart #33444

Closed
MilenVolf opened this issue Nov 21, 2024 · 0 comments · Fixed by #33578
Closed

Borgs don't get names on roundstart #33444

MilenVolf opened this issue Nov 21, 2024 · 0 comments · Fixed by #33578
Labels
A: Silicons Area: Relates to Silicon roles, including AI. D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Bugfix Type: Bugs and/or bugfixes

Comments

@MilenVolf
Copy link
Contributor

Description

When I was correcting dataset prototypes ids in #33352 I found out that names_borg has no usages.
Probably was removed in #32586 with PlayerBorgGeneric prototype

Reproduction

  1. Choose borg role
  2. Spawn as a borg on the station
  3. Has just cyborg name

Screenshots

image

Additional context
Should be pretty easy to fix by putting type: RandomMetadata with chosen name dataset prototype.
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 21, 2024
@Boaz1111 Boaz1111 added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: Silicons Area: Relates to Silicon roles, including AI. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Bugfix Type: Bugs and/or bugfixes and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 25, 2024
@ScarKy0 ScarKy0 added the Issue: Replicated This issue has been replicated by another user. label Nov 25, 2024
@Winkarst-cpu Winkarst-cpu mentioned this issue Nov 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: Silicons Area: Relates to Silicon roles, including AI. D3: Low Difficulty: Some codebase knowledge required. Issue: Replicated This issue has been replicated by another user. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix borgs not getting names on roundstart Winkarst-cpu/space-station-14
3 participants
@MilenVolf @ScarKy0 @Boaz1111