Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Living can see the fingers of the dead #5454

Closed
Streaky-Haddock opened this issue Nov 22, 2021 · 8 comments
Closed

The Living can see the fingers of the dead #5454

Streaky-Haddock opened this issue Nov 22, 2021 · 8 comments
Labels
Issue: Replicated This issue has been replicated by another user. T: Bugfix Type: Bugs and/or bugfixes

Comments

@Streaky-Haddock
Copy link

Description

When ghosts point, the living can see it.

Screenshots
image

Additional context

@gradientvera
Copy link
Contributor

this bug is gonna haunt us for the rest of time

@moonheart08
Copy link
Contributor

this is like the fourth time oh my god

@xRiriq
Copy link
Contributor

xRiriq commented Nov 22, 2021

There's one person who has been abusing the hell out of it lately. Can we put a rate limiter on it too (in case it is a hard fix)? As I usually play medical roles it's ridiculous. Thankfully one of those rounds was an antag round so I could just throw them in a locker instead of cloning.

@Acruid
Copy link
Contributor

Acruid commented Nov 23, 2021

Has anyone had success reproducing this locally?

@xRiriq
Copy link
Contributor

xRiriq commented Nov 23, 2021

Yes:

  1. start local debug server
  2. start 2 local debug clients
  3. punch one client to crit

image

  1. punch that same client to dead

image

Seems pretty straightforward to induce the state in question.

@Acruid
Copy link
Contributor

Acruid commented Nov 24, 2021

Ok, so it's dead players still being able to point, before turning into ghosts. OP said it was ghosts pointing, which is not the problem.

@Streaky-Haddock
Copy link
Author

My mistake!

@Acruid Acruid added Issue: Replicated This issue has been replicated by another user. T: Bugfix Type: Bugs and/or bugfixes labels Nov 24, 2021
@ElectroJr
Copy link
Member

My mistake!

So if I understand correctly this has nothing to do with ghosts and is just about incapacitated players. In that case this is a duplicate of #2774 so closing this.

and as for @xRiriq's comment:

Can we put a rate limiter on it too (in case it is a hard fix)

pointing already has a 0.5s delay limiting the rate, which is fine IMO. Or was this being bypassed somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Replicated This issue has been replicated by another user. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

No branches or pull requests

6 participants