Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection of quantities #224

Closed
nden opened this issue Jun 21, 2019 · 0 comments · Fixed by #457
Closed

Improve detection of quantities #224

nden opened this issue Jun 21, 2019 · 0 comments · Fixed by #457
Milestone
1.0

Comments

@nden
Copy link
Collaborator

nden commented Jun 21, 2019

The wcs object attempts to identify if the inputs are quantities in utils.isnumeric. This fails on ndarrays of certain dtypes. A more robust way to figure this out is needed.

An example of failure is a spec_table['wavelength'] column in a JWST SpecModel for which the dtype is >f8.
@nden nden added this to the 0.11 milestone Jun 21, 2019
@nden nden modified the milestones: 0.11, 1.0 Mar 16, 2020
@spacetelescope spacetelescope deleted a comment from stscijgbot Jun 3, 2023
@Cadair Cadair mentioned this issue Oct 12, 2023
Merged
@nden nden closed this as completed in #457 Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Spring cleaning coordinate frames Cadair/gwcs
1 participant
@nden