Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maxversion pin of scipy #446

Closed
pllim opened this issue Mar 17, 2023 · 1 comment
Closed

Remove maxversion pin of scipy #446

pllim opened this issue Mar 17, 2023 · 1 comment

Comments

@pllim
Copy link
Contributor

pllim commented Mar 17, 2023

gwcs/setup.cfg

Line 26 in 7b32eb5

scipy < 1.10.0

Max version pin is not sustainable and should be removed as soon as upstream issues are fixed (which look like they are?). This pin here prevents downstream packages from upgrading scipy while relying on GWCS, which in turn prevents them from testing against dev version of GWCS and dev version of scipy.

Related issues:

@pllim
Copy link
Contributor Author

pllim commented Mar 17, 2023

In the future, please:

  • open a follow-up issue to remove maxversion pin; it was mentioned in Pin gwcs due to scipy issue #435 but once that was merged, there is a high risk of any follow-up to be forgotten without an explicit issue to do the follow-up;
  • maybe consider using != pin if you know it is going to be fixed upstream by their next bugfix; e.g., scipy != 1.10.0

@nden nden closed this as completed Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants