Windows setup.py: relpath breaks when Python and code on different disks

[Jdaviz-Triage-Bot]

Reporter: pllim

Cannot run editable install when Python itself is installed on one disk (say, C:) and the source code checkout of this package is on another disk (say, D:). You will get error like this:

ValueError: path is on mount 'D:', start on mount 'C:'

jdaviz/setup.py

Line 134 in 0712a8c

rel_source = os.path.relpath(os.path.abspath(

Example source path: D:\...\jdaviz\share\jupyter\nbconvert\templates\jdaviz-default
Example destination path: C:\...\Miniconda3\envs\py38\share\jupyter\nbconvert\templates

Also see #925 (comment)

🐱

---

DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

[pllim]

@maartenbreddels , is relpath really necessary?

[maartenbreddels]

Not needed, but it makes it more flexible, but an abspath could also work. I'm not sure though that windows can do a symlink pointing to a different drive.

[pllim]

I used to think Windows can't do symlink, period, but maybe that has changed... 🤷

[pllim]

#1218 reverted because of 🍎