Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imviz: AsdfInFits removal from ASDF 3.0 #1980

Closed
2 tasks
braingram opened this issue Jan 25, 2023 · 1 comment · Fixed by #2052
Closed
2 tasks

Imviz: AsdfInFits removal from ASDF 3.0 #1980

braingram opened this issue Jan 25, 2023 · 1 comment · Fixed by #2052

Comments

@braingram
Copy link
Contributor

braingram commented Jan 25, 2023

ignore:AsdfInFits has been deprecated

The ability to read AsdfInFits files is being moved from ASDF into stdatamodels (in part to consolidate non-pipeline code for jwst). The current plan for this move is:

We do not have a estimate for when a stable version of stdatamodels or ASDF 3.0 will be released. We are planning to release ASDF 2.15 (which will support AsdfInFits) in the next few weeks which we will continue to support for at least 1 year (please see our proposed release and support process).

To summarize, at some point in the next year or so the following uses of AsdfInFits in jdaviz will need to be updated to use stdatamodels.

with AsdfInFits.open(file_obj) as af:

ff = AsdfInFits(hdulist, tree)

I mentioned this to @pllim and am happy to discuss alternatives, suggestions, comments on this process and hope to make it as painless as possible.

🐱

Also see astropy/specutils#1006

@braingram braingram added bug Something isn't working imviz labels Jan 25, 2023
@pllim pllim changed the title [BUG] Imviz: AsdfInFits removal from ASDF 3.0 Imviz: AsdfInFits removal from ASDF 3.0 Jan 25, 2023
@pllim pllim added Upstream fix required and removed bug Something isn't working labels Jan 25, 2023
@braingram
Copy link
Contributor Author

To provide a minor update to this issue, a version of stdatamodels with AsdfInFits support has been released:
https://pypi.org/project/stdatamodels/1.1.0/
with documentation on reading and writing AsdfInFits files: https://stdatamodels.readthedocs.io/en/latest/asdf_in_fits.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants