From a4ff3a9456ccd538d8b8f1288535a782064d11ba Mon Sep 17 00:00:00 2001 From: Mike Regan Date: Thu, 29 Feb 2024 12:46:35 -0500 Subject: [PATCH 1/3] deleted test that was moved to STCAL --- jwst/jump/tests/test_detect_jumps.py | 45 ---------------------------- 1 file changed, 45 deletions(-) diff --git a/jwst/jump/tests/test_detect_jumps.py b/jwst/jump/tests/test_detect_jumps.py index ccc393e022..fc7c902547 100644 --- a/jwst/jump/tests/test_detect_jumps.py +++ b/jwst/jump/tests/test_detect_jumps.py @@ -307,51 +307,6 @@ def test_multiple_neighbor_jumps_firstlastbad(setup_inputs): assert_array_equal(out_model.groupdq[0, :, 4, 4], [1, 0, 0, 0, 0, 0, 0, 0, 0, 1]) -def test_nirspec_saturated_pix(setup_inputs): - """ - This test is based on an actual NIRSpec exposure that has some pixels - flagged as saturated in one or more groups, which the jump step is - supposed to ignore, but an old version of the code was setting JUMP flags - for some of the saturated groups. This is to verify that the saturated - groups are no longer flagged with jumps. - """ - grouptime = 3.0 - ingain = 1.0 - inreadnoise = 10.7 - ngroups = 7 - nrows = 6 - ncols = 6 - - model, rnoise, gain = setup_inputs(ngroups=ngroups, nints=1, nrows=nrows, - ncols=ncols, gain=ingain, - readnoise=inreadnoise, deltatime=grouptime) - - # Setup the needed input pixel and DQ values - model.data[0, :, 1, 1] = [639854.75, 4872.451, -17861.791, 14022.15, 22320.176, - 1116.3828, 1936.9746] - model.groupdq[0, :, 1, 1] = [0, 0, 0, 0, 0, 2, 2] - model.data[0, :, 2, 2] = [8.25666812e+05, -1.10471914e+05, 1.95755371e+02, 1.83118457e+03, - 1.72250879e+03, 1.81733496e+03, 1.65188281e+03] - # 2 non-sat groups means only 1 non-sat diff, so no jumps should be flagged - model.groupdq[0, :, 2, 2] = [0, 0, 2, 2, 2, 2, 2] - model.data[0, :, 3, 3] = [1228767., 46392.234, -3245.6553, 7762.413, - 37190.76, 266611.62, 5072.4434] - model.groupdq[0, :, 3, 3] = [0, 0, 0, 0, 0, 0, 2] - - # run jump detection - out_model = run_detect_jumps(model, gain, rnoise, rejection_thresh=200.0, three_grp_thresh=200, - four_grp_thresh=200, - max_cores='none', max_jump_to_flag_neighbors=200, - min_jump_to_flag_neighbors=10, flag_4_neighbors=True) - - # Check the results. There should not be any pixels with DQ values of 6, which - # is saturated (2) plus jump (4). All the DQ's should be either just 2 or just 4. - assert_array_equal(out_model.groupdq[0, :, 1, 1], [0, 4, 4, 4, 0, 2, 2]) - # assert that no groups are flagged when theres only 1 non-sat. grp - assert_array_equal(out_model.groupdq[0, :, 2, 2], [0, 0, 2, 2, 2, 2, 2]) - assert_array_equal(out_model.groupdq[0, :, 3, 3], [0, 4, 4, 0, 0, 4, 2]) - - def add_crs(model, crs_frac): """" Randomly add a cosmic ray of magnitude CR_MAG to a fraction (crs_frac) From ace8179c1da85b84270a155276a397f1876e2dbc Mon Sep 17 00:00:00 2001 From: Mike Regan Date: Thu, 29 Feb 2024 12:51:33 -0500 Subject: [PATCH 2/3] Update CHANGES.rst --- CHANGES.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGES.rst b/CHANGES.rst index cc68fdd09f..e886ad4108 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -68,6 +68,11 @@ extract_1d - Replaced instances of deprecated interp2d with RectBivariateSpline in ``apply_apcorr``. [#8291] +jump +---- +Removed a unit test in Jump that was moved to STCAL to decrease +the coupling of the two repos. [#8319] + extract_2d ---------- From e2b5a6f8385d95552530adb2ad40fc753aab4655 Mon Sep 17 00:00:00 2001 From: Howard Bushouse Date: Fri, 1 Mar 2024 07:56:00 -0500 Subject: [PATCH 3/3] Update CHANGES.rst --- CHANGES.rst | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index e886ad4108..c15f694984 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -8,7 +8,7 @@ associations sub-pixel dithers, so that only exposures from other nod positions are used as background members in "spec2" associations. [#8184] -- JP-3290 Isolate candidate processing into their own pools [#8227] +- Isolate candidate processing into their own pools [#8227] cube_build ---------- @@ -68,11 +68,6 @@ extract_1d - Replaced instances of deprecated interp2d with RectBivariateSpline in ``apply_apcorr``. [#8291] -jump ----- -Removed a unit test in Jump that was moved to STCAL to decrease -the coupling of the two repos. [#8319] - extract_2d ---------- @@ -85,6 +80,12 @@ general - Update minimum required photutils version to 1.5.0 [#8211] +jump +---- + +- Removed a unit test in Jump that was moved to STCAL to decrease + the coupling of the two repos. [#8319] + outlier_detection -----------------