Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-202: add origin definitions for RSDP #544

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

PaulHuwe
Copy link
Collaborator

Resolves RAD-202

Closes #543

This PR changes some RSDP origin values.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (32af770) to head (77fd7ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files           4        4           
  Lines         266      266           
=======================================
  Hits          257      257           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe requested review from WilliamJamieson and a team as code owners February 13, 2025 17:48
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Checking my understanding---these changes are entirely ~documentation and inform how SDF places these fields in the database but don't impact romancal / roman_datamodels code and are ultimately only advisory to SDF at present?

@PaulHuwe
Copy link
Collaborator Author

This looks fine to me. Checking my understanding---these changes are entirely ~documentation and inform how SDF places these fields in the database but don't impact romancal / roman_datamodels code and are ultimately only advisory to SDF at present?

Correct - these have zero impact on RDM.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, then let's get this in, thanks.

@PaulHuwe PaulHuwe merged commit cd5b303 into spacetelescope:main Feb 13, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add origin definitions for RSDP
4 participants