Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update branch URLs in docs for master -> stable (or develop, as appropriate) #372

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Jun 24, 2020

same as in the corresponding poppy PR

@mperrin mperrin requested a review from shanosborne June 24, 2020 00:48
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #372 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #372   +/-   ##
========================================
  Coverage    47.39%   47.39%           
========================================
  Files           13       13           
  Lines         5562     5562           
========================================
  Hits          2636     2636           
  Misses        2926     2926           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83989c...e97f00d. Read the comment docs.

Copy link
Contributor

@shanosborne shanosborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw a few other links that should probably be changed:

  • In release.rst, change the astroconda/astroconda-constrib/master to /develop is the 2 places it shows up (lines 82 and 83). This is the same changes as in poppy's release.rst file could also be made to webbpsf
  • Update line 106 of docs/installation.rst
  • Update line 115 in docs/intro.rst

@@ -7,13 +7,17 @@ WebbPSF: Simulated Point Spread Functions for the James Webb and Nancy Grace Rom
:target: https://pypi.python.org/pypi/webbpsf
:alt: Badge showing current released PyPI version

.. image:: https://travis-ci.org/spacetelescope/webbpsf.svg?branch=master
.. image:: https://travis-ci.org/spacetelescope/webbpsf.svg?branch=develop
:target: https://travis-ci.org/spacetelescope/webbpsf
:alt: Badge showing continuous integration test status

.. image:: https://codecov.io/gh/spacetelescope/webbpsf/branch/master/graph/badge.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be switched to "stable" too

@mperrin
Copy link
Collaborator Author

mperrin commented Jun 24, 2020

In release.rst, change the astroconda/astroconda-constrib/master to /develop is the 2 places it shows up (lines 82 and 83). This is the same changes as in poppy's release.rst file could also be made to webbpsf

This one turns out not to be the case - astroconda-contrib is using 'master' as the branch name and there isn't a develop branch. So I left this as-is, and made the other two suggestions.

@mperrin mperrin merged commit ec397a1 into spacetelescope:develop Jun 25, 2020
@mperrin mperrin deleted the update_branch_urls branch November 6, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants