Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate SI WFE header keyword over just the JWST aperture, not the full array #427

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Mar 4, 2021

Minor fix to header keywords, discovered while cross-checking output PSFs with the lookup table grid.

The header keyword "SI_WFE" should give the RMS WFE evaluated just over the JWST aperture, not the full SI WFE aperture (which may be a circular aperture circumscribing the JWST pupil, or may be a full array with no mask; either way, that's not what we should use)

This has no effect on the output PSFs at all. It just makes one header keyword a bit more accurate.

@mperrin mperrin added the JWST Affects JWST models in WebbPSF label Mar 4, 2021
@mperrin mperrin requested a review from Skyhawk172 March 4, 2021 21:20
@mperrin mperrin self-assigned this Mar 4, 2021
@mperrin mperrin force-pushed the fix-si-wfe-keyword branch from 50b512c to 7a4f5db Compare April 2, 2021 05:08
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #427 (7a4f5db) into develop (7755bc1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #427      +/-   ##
===========================================
+ Coverage    48.46%   48.50%   +0.04%     
===========================================
  Files           14       14              
  Lines         5877     5878       +1     
===========================================
+ Hits          2848     2851       +3     
+ Misses        3029     3027       -2     
Impacted Files Coverage Δ
webbpsf/webbpsf_core.py 81.00% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7755bc1...7a4f5db. Read the comment docs.

@mperrin mperrin requested a review from shanosborne April 2, 2021 21:00
@mperrin mperrin merged commit 80433ea into spacetelescope:develop Apr 5, 2021
@mperrin mperrin deleted the fix-si-wfe-keyword branch April 5, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JWST Affects JWST models in WebbPSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants