Update trending plot to subtract piston before displaying proposed correction #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi-wan76
approved these changes
Oct 16, 2023
|
@BradleySappington can you check this merge? Thanks! |
Merged
|
@mperrin - please rebase to get the CI legacy test fix |
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
@obi-wan76 @mperrin, mentioned a few weeks back (although cycle deadline was in full force when I mentioned it!). Please re-base to get the CI legacy fix :) |
…playing proposed correction OPD
mperrin
force-pushed
the
trending_plot_improve_correction_display
branch
from
867d3b7 to
e3eea15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WSS doesn't subtract piston from the proposed correction that it writes out in the OPD files. (The MCS does subsequently remove global piston before generating SURs).
This PR changes the display code in single_measurement_trending_plot so it subtracts the piston before displaying the proposed correction. This also affects the computed RMS WFE values, removing a bias that was making those appear higher. (related to the subtle distinction between the RMS and the std dev, which the WSS code handles differently in various cases).
Before and after plots. Only change is in the marked panel in the bottom row:
Before (with current code):
After this PR (with proposed modified code)