-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nrc_ta_image_comparison
function to trending tools
#789
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #789 +/- ##
===========================================
- Coverage 54.78% 54.34% -0.45%
===========================================
Files 16 16
Lines 6558 6621 +63
===========================================
+ Hits 3593 3598 +5
- Misses 2965 3023 +58 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good and it works as expected. I have a similar "residual" function that uses make_residual_image
from PSFPhotometry
in photutils.psf
. I wonder if there is a way to quantify the residual image beside the visual inspection (stdev?)
To quantify, a straightforward step would be to compute Chi^2, using the pipeline ERR extension estimate of the uncertainties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, nice addition. Thanks!
This adds a function
nrc_ta_image_comparison
which retrieves the TA image for a given visit, generates a matching simulation, and displays their difference. Useful as a check for binary.For example, in particular 4502:126...