Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace NaN with nan for numpy 2.0 prep #791

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

BradleySappington
Copy link
Collaborator

small updates for transition to numpy 2.0

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (064dc08) 55.12% compared to head (e2c4e1b) 55.12%.

Files Patch % Lines
webbpsf/utils.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #791   +/-   ##
========================================
  Coverage    55.12%   55.12%           
========================================
  Files           16       16           
  Lines         6625     6625           
========================================
  Hits          3652     3652           
  Misses        2973     2973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@obi-wan76
Copy link
Collaborator

The new lines are not covered by tests

@obi-wan76 obi-wan76 merged commit 01fa6a7 into spacetelescope:develop Feb 3, 2024
8 of 9 checks passed
@BradleySappington BradleySappington deleted the numpy_prep branch May 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants