avoid linear interpolation between WFE values

[mperrin]

As discussed on slack with @tracy-beck and Matt Lallo, it's better for the WFE histogram not to interpolate between points when inferring WFE at times in between our measurements.

Before this PR:

With this PR:

[pep8speaks]

Hello @mperrin, Thank you for updating !

• In the file webbpsf/trending.py:

Line 93:9: E265 block comment should start with '# '
Line 95:9: E265 block comment should start with '# '
Line 96:9: E265 block comment should start with '# '
Line 102:9: E265 block comment should start with '# '
Line 301:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 303:27: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 384:35: E203 whitespace before ':'
Line 463:1: E266 too many leading '#' for block comment
Line 700:5: E266 too many leading '#' for block comment
Line 715:5: E266 too many leading '#' for block comment
Line 762:5: E266 too many leading '#' for block comment
Line 785:5: E266 too many leading '#' for block comment
Line 945:5: E266 too many leading '#' for block comment
Line 1032:49: W605 invalid escape sequence '\D'
Line 1068:1: E266 too many leading '#' for block comment
Line 1097:43: E203 whitespace before ':'
Line 1187:5: E722 do not use bare 'except'
Line 1340:5: E266 too many leading '#' for block comment
Line 1364:5: E266 too many leading '#' for block comment
Line 1384:22: W605 invalid escape sequence '\D'
Line 1703:126: E501 line too long (146 > 125 characters)
Line 1733:5: E731 do not assign a lambda expression, use a def
Line 2021:25: W605 invalid escape sequence '\D'
Line 2029:1: E266 too many leading '#' for block comment
Line 2108:9: E266 too many leading '#' for block comment
Line 2134:126: E501 line too long (142 > 125 characters)
Line 2145:13: E266 too many leading '#' for block comment
Line 2178:9: E266 too many leading '#' for block comment

Comment last updated at 2024-05-12 04:10:35 UTC

[mperrin]

Ping to @tracy-beck, would you have a moment to review this GitHub PR for the histogram fix that I chatted about with you and Matt? Thanks

[mperrin]

@kulpster85 might you be available to review this PR, perhaps? It's pretty straightforward I think. I had asked Tracy (who had originally pointed out this bug to me along with Matt L.) but it sounds like she may not be available to review this PR due to other things on her plate.

[kulpster85]

@mperrin yes I can take a look

[kulpster85]

Looks good to me.

[mperrin]

@kulpster85 approved this PR. Despite that, Github is for some reason still showing "Review Required, at least 1 approving review is still required". Rather than spend time debugging why Github is confused, I'm going to simply merge anyway despite that warning.