Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more strict units handling; fixes some issues for astropy 6.0.0 compatibility #879

Merged
merged 2 commits into from
Jul 8, 2024
Merged

more strict units handling; fixes some issues for astropy 6.0.0 compatibility #879

merged 2 commits into from
Jul 8, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Jul 8, 2024

Fixes problem with calc_datacube_fast as reported in Slack.

@mperrin mperrin added bug Something isn't working JWST Affects JWST models in WebbPSF labels Jul 8, 2024
@mperrin mperrin requested a review from obi-wan76 July 8, 2024 19:37
@mperrin mperrin self-assigned this Jul 8, 2024
obi-wan76
obi-wan76 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the previous error: UnitConversionError: Can only apply 'less' function to dimensionless quantities when other argument is not a quantity (unless the latter is all zero/infinity/nan).

@obi-wan76 obi-wan76 merged commit 89fcb26 into spacetelescope:develop Jul 8, 2024
7 checks passed
@obi-wan76 obi-wan76 mentioned this pull request Dec 16, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi-wan76 obi-wan76 obi-wan76 approved these changes

Assignees

@mperrin mperrin

Labels
bug Something isn't working JWST Affects JWST models in WebbPSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mperrin @obi-wan76