Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix missing data/ directory when downloading + caching data #885

Merged

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Jul 17, 2024

when running download_data.yml, the data/ directory doesn't exist, so tar can't extract into it. Additionally, version.txt is now at data/webbpsf-data/version.txt

@zacharyburnett zacharyburnett changed the title fix missing data/ directory when downloading + caching data [CI] fix missing data/ directory when downloading + caching data Jul 17, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review July 17, 2024 13:01
Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, not sure why tests are failing

@zacharyburnett
Copy link
Contributor Author

after merging this, rerunning https://github.com/spacetelescope/webbpsf/actions/workflows/download_data.yml will fix the failing tests (the cache misses due to a different path)

@BradleySappington
Copy link
Collaborator

Roger that!

@BradleySappington BradleySappington merged commit 6dd0cd7 into spacetelescope:develop Jul 17, 2024
4 of 8 checks passed
@zacharyburnett zacharyburnett deleted the ci/create_data_dir branch July 17, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants