Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to docs about the WFI optical model #936

Merged
merged 11 commits into from
Dec 4, 2024

Conversation

Skyhawk172
Copy link
Collaborator

This PR adds a note about the current WFI optical model and the ongoing work to implement the new one. The note is added to (1) README.rst and (2) roman.rst.

After a few tries, I think the rendition on Github and readthedocs should be as expected.

@Skyhawk172 Skyhawk172 requested a review from obi-wan76 November 27, 2024 16:05
@Skyhawk172 Skyhawk172 self-assigned this Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.26%. Comparing base (490d6bf) to head (948d3f2).
Report is 42 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #936      +/-   ##
===========================================
+ Coverage    62.15%   62.26%   +0.10%     
===========================================
  Files           15       15              
  Lines         7016     7038      +22     
===========================================
+ Hits          4361     4382      +21     
- Misses        2655     2656       +1     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@obi-wan76 obi-wan76 merged commit 6cad95d into spacetelescope:develop Dec 4, 2024
10 checks passed
@Skyhawk172 Skyhawk172 deleted the readme_update branch December 13, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants