-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebbPSF to STPSF #951
WebbPSF to STPSF #951
Conversation
Hello @BradleySappington, Thank you for updating ! There are no PEP8 issues in this Pull Request. Comment last updated at 2024-12-19 15:30:54 UTC |
Read the docs redirect. Is there a way to make that global across all pages? Would we need to put that redirect text on each of the individual RST pages? Thanks so much for all the work on this -- so many little details to keep track of! |
@mperrin - I don't actually think this readthedocs redirect is needed. I created a domain redirect through readthedocs admin settings and have successfully tested (I just have it deactivated currently) |
superb, I'm glad to hear that there's a way to do a domain redirect, and that you've already figured it out! :-) |
I removed some of the workflows as we are now importing everything from stpsf (including tests) they are failing here. No sense in spending time making the workflows functional to archive the repo in a few months so I removed them. Will not merge until confirmed everyone is comfortable with these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable way to start the sunset process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall, but (a) I think we should not go quite so far in cutting out the test suite, and (b) as discussed in slack let's make a docs page about the name migration rather than trying to put all the info in a warning message.
Some tests marked expected and not actually running, trying a reboot |
@mperrin - At your convenience, can you please update requested change as complete per slack conversation. Thanks! |
@obi-wan76 - the requested changes have been addressed via slack. The tests are passing. I'm going to override the merge restriction as the data-cache update fixed in this PR is currently affecting romancal |
transition webbpsf to stpsf alias