Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebbPSF to STPSF #951

Merged
merged 29 commits into from
Feb 14, 2025
Merged

WebbPSF to STPSF #951

merged 29 commits into from
Feb 14, 2025

Conversation

BradleySappington
Copy link
Collaborator

transition webbpsf to stpsf alias

@pep8speaks
Copy link

pep8speaks commented Dec 16, 2024

Hello @BradleySappington, Thank you for updating !

There are no PEP8 issues in this Pull Request.

Comment last updated at 2024-12-19 15:30:54 UTC

@BradleySappington BradleySappington changed the title import stpsf DRAFT: WebbPSF to STPSF Dec 16, 2024
@mperrin
Copy link
Collaborator

mperrin commented Dec 16, 2024

Read the docs redirect. Is there a way to make that global across all pages? Would we need to put that redirect text on each of the individual RST pages?

Thanks so much for all the work on this -- so many little details to keep track of!

@BradleySappington
Copy link
Collaborator Author

BradleySappington commented Dec 16, 2024

@mperrin - I don't actually think this readthedocs redirect is needed. I created a domain redirect through readthedocs admin settings and have successfully tested (I just have it deactivated currently)

@mperrin
Copy link
Collaborator

mperrin commented Dec 16, 2024

superb, I'm glad to hear that there's a way to do a domain redirect, and that you've already figured it out! :-)

@BradleySappington BradleySappington changed the title DRAFT: WebbPSF to STPSF WebbPSF to STPSF Dec 16, 2024
@BradleySappington BradleySappington self-assigned this Dec 16, 2024
@BradleySappington
Copy link
Collaborator Author

I removed some of the workflows as we are now importing everything from stpsf (including tests) they are failing here. No sense in spending time making the workflows functional to archive the repo in a few months so I removed them. Will not merge until confirmed everyone is comfortable with these changes.

Copy link
Collaborator

@york-stsci york-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable way to start the sunset process

Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall, but (a) I think we should not go quite so far in cutting out the test suite, and (b) as discussed in slack let's make a docs page about the name migration rather than trying to put all the info in a warning message.

@BradleySappington BradleySappington marked this pull request as draft February 11, 2025 20:19
@BradleySappington
Copy link
Collaborator Author

Some tests marked expected and not actually running, trying a reboot

@BradleySappington BradleySappington marked this pull request as ready for review February 12, 2025 16:49
@BradleySappington
Copy link
Collaborator Author

@mperrin - At your convenience, can you please update requested change as complete per slack conversation. Thanks!

@BradleySappington
Copy link
Collaborator Author

@obi-wan76 - the requested changes have been addressed via slack. The tests are passing. I'm going to override the merge restriction as the data-cache update fixed in this PR is currently affecting romancal

@BradleySappington BradleySappington merged commit 6fc889a into develop Feb 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants