Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix download workflow #959

Closed

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 13, 2025

The download workflow is failing for romancal resulting in failures downloading webbpsf data:
https://github.com/spacetelescope/romancal/actions/runs/13316268671

This is likely due to changes to the actions/cache infrastruction:
https://github.com/actions/cache/releases/tag/v4.2.0
with the important bit being:

We are deprecating some versions of this action. We recommend upgrading to version v4 or v3 as soon as possible before February 1st, 2025. (Upgrade instructions below).

If you are using pinned SHAs, please use the SHAs of versions v4.2.0 or v3.4.0

If you do not upgrade, all workflow runs using any of the deprecated actions/cache will fail.

Since the workflow has an exact pin to v4.0.2 this may explain why the caches suddenly started failing.

@braingram
Copy link
Contributor Author

@BradleySappington I can't seem to request reviewers. Would you be able to do this for me?

@braingram
Copy link
Contributor Author

It looks like the caches here are similarly impacted. The fix in this PR won't work until merged, a cache is updated (I see none for this repository) and the pin updated here:

uses: spacetelescope/webbpsf/.github/workflows/retrieve_cache.yml@beda656c80a0254e6f80649d9c9c49235634522f # v1.4.0

Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is being handled already in a separate PR, thank you though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants