Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy: do not send deprecated headers #647

Closed
2 tasks done
flavorjones opened this issue Jul 18, 2024 · 2 comments · Fixed by #648
Closed
2 tasks done

tidy: do not send deprecated headers #647

flavorjones opened this issue Jul 18, 2024 · 2 comments · Fixed by #648

Comments

@flavorjones
Copy link
Member

flavorjones commented Jul 18, 2024

See discussion at #646 which indicates that sending the now-deprecated accept-charset header confuses some (presumably buggy, but real-world) servers.

I'm opening this ticket to drive:

Special thank-you to @MarcoPrins and @tomasz-jasiulek for reporting and investigating this.

@flavorjones
Copy link
Member Author

Inventory

A vanilla request sends the following headers:

  • accept-charset => ISO-8859-1,utf-8;q=0.7,*;q=0.7
  • accept-encoding => gzip,deflate,identity
  • accept-language => en-us,en;q=0.5
  • accept => */*
  • host
  • user-agent

accept-charset

See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Charset

Warnings: "Do not use this header. Browsers omit this header and servers should ignore it."

accept-encoding

See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding

Warnings: none

accept-language

See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Language

Warnings: none

accept

See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept

Warnings: none

user-agent

See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent

Warnings: only to servers about browser detection using the user agent being a bad idea

host

See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host

Warnings: none

@flavorjones
Copy link
Member Author

Seems like accept-charset is the only offender. See #648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant