reset the namespace cache when replacing the document's innerHtml #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the reset is needed to associated the namespace info with the nodes fixes sparklemotion#1180 Sponsored by Lookout Inc.
|
Is there anything holding back the merge of this pull request? |
|
Hi, Sorry for the delay in responding. Thanks for sending this PR! The only thing holding it back is the lack of my personal time over the last month. I'm extremely hopeful that I'll get a chunk of time over the next week to devote to Nokogiri, and I'll make sure to handle this PR. Thanks for your patience. |
|
Pinging @jvshahid for the assist. John - this is a JRuby-specific PR that's blocking 1.6.7. Can you take a look, and if it's OK, merge it? |
|
taking a look at it right now |
|
Thanks @mkristian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reset is needed to associated the namespace info with the nodes
fixes #1180
Sponsored by Lookout Inc.