Ensure namespace pruning is not over zealous #1444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespace pruning would previously consider the same namespace URI as equivalent even though the prefix in use may have differed. Thus child nodes added with a different prefix for an already known namespace would cause the resulting document to become schema invalid.
|
@flavorjones any further thoughts on merging this or #1333 for the next 1.6.8 RC? Any idea on timelines if so? |
flavorjones
added a commit
that referenced
this pull request
May 30, 2016
and adding tests for reparented nodes' namespaces related to #1332
flavorjones
added a commit
that referenced
this pull request
May 30, 2016
and adding test for matching parent's default ns related to #1332
|
I've merged some of your tests from this PR into master, and I've given you credit in the commit log. Apologies I couldn't figure out a better way to keep your name on the commits. Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace pruning would previously consider the same namespace URI as
equivalent even though the prefix in use may have differed.
Thus child nodes added with a different prefix for an already known
namespace would cause the resulting document to become schema invalid.