Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Windows fat gem for Ruby 2.5 #1706

Closed
Hazardius opened this issue Jan 1, 2018 · 2 comments
Closed

Release Windows fat gem for Ruby 2.5 #1706

Hazardius opened this issue Jan 1, 2018 · 2 comments

Comments

@Hazardius
Copy link

Hazardius commented Jan 1, 2018

Just a notice about issue with nokogiri fat gem 1.8.1 on Windows machines.
Current release informs about ruby version not being <2.5 .
Will it be supported with a new release - 1.8.2?

Issue name based on #1618 .

@rational-gamer
Copy link

rational-gamer commented Jan 3, 2018

I'm also interested in such support, the latest 2.5 version of ruby is assumed to have many time optimization and some syntaxical sugar that can help to improve code readability.

The only non backward change that I can find is https://bugs.ruby-lang.org/issues/11547, but it shouldn't impact any well written code. In my opinion, reference to a variable in a namespace should not assume that it can be defined at top level rather than in the namespace context.

EDIT 2018-01-04:

@Hazardius
Copy link
Author

EDIT 2018-01-04:
As above - sorry that I didn't checked pull requests. Closing the issue as it's already waiting there at #1704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants